Noticed while reading the code for something else that https://git.drupalcode.org/project/group_permissions/-/blob/2.0.x/src/Co... calls GroupPermissionsManagerInterface::getGroupRoles() which I think I'm correct in saying has been removed. The form replaced it with a method https://git.drupalcode.org/project/group_permissions/-/blob/2.0.x/src/Fo...
Sorry if it's already on the todo. But thought it best to log when I spotted it. I've not actually tried to view a revision...
Repeat the method code, it's trivial? Move it somewhere?
Fixed
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
So, the "getGroupRoles" method present in 1.0.0 was deleted in 2.0.0, and replaced by the "getNonAdminRoles" method, right?
I was taking a look at both methods, to check their differences. Although both are listing group roles, are they indeed equal? The latter seems to ignore admin roles, with the former seeming to get all roles without distinction. Will it give the same results regardless, or should we take that into consideration when updating 1.0.0 to 2.0.0 as well?