Supporting patch for "EntityReferenceFieldItemList::referencedEntities should return the translated entity" in core

Created on 11 November 2022, over 1 year ago

Updated 16 February 2024, 4 months ago

Problem/Motivation

In case patch in EntityReferenceFieldItemList::referencedEntities should return the translated entity → is used, then it leads to an error when using err as follows,
Fatal error: Declaration of Drupal\entity_reference_revisions\EntityReferenceRevisionsFieldItemList::referencedEntities() must be compatible with Drupal\Core\Field\EntityReferenceFieldItemList::referencedEntities(?string $langcode = NULL) in /var/www/html/web/modules/contrib/entity_reference_revisions/src/EntityReferenceRevisionsFieldItemList.php on line 21

Steps to reproduce

Apply patch in - https://www.drupal.org/node/2915972 →
Try to visit a form where ERR fields is used.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇩🇪Germany D34dMan Hamburg

Live updates comments and jobs are added and updated live.

Incomplete comments

Merge Requests

!40Supporting patch for "EntityReferenceFieldItemList::referencedEntities should return the translated entity" in core
Open
🇮🇳India chetan 11
updated 4 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 4 months ago →
🇸🇮Slovenia mkrizaj
Attaching new patch for latest version.
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update 4 months ago
40 pass
Comment 4 months ago →
🇮🇳India chetan 11
chetan 11 → made their first commit to this issue’s fork.
Merge request !40fixed → (Open) created by chetan 11
Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 4 months ago
Not currently mergeable.
Status changed to Needs review 4 months ago6:09am 15 February 2024
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 4 months ago
Patch Failed to Apply
Comment 4 months ago →
🇮🇳India chetan 11
please check the above MR.
Comment 4 months ago →
🇩🇪Germany D34dMan Hamburg
@mkrizaj,

The patch in #5 is same as the one posted in #1, could you explain why?

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024