Fix the issues reported by phpcs

Verified the patch #14 and tested it on Drupal version 10.1.x and PDF Reader 3.x. The patch works fine and errors mentioned in the tickets are fixed. I have added the screenshots for reference. But there is one warning

FILE: .../pdf_reader/src/Plugin/Field/FieldFormatter/FieldPdfReaderField.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 180 | WARNING | [x] A comma should follow the last multiline array item. Found: )
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

Time: 143ms; Memory: 10MB

Comment over 2 years ago →
System Message

penyaskito → committed d8a90a08 on 8.x-1.x authored by apaderno →
Issue #3319449 by ayush.khare, SandeepSingh199, apaderno, priyankapatel...
Status changed to Fixed over 2 years ago2:59pm 31 January 2023

Comment over 2 years ago →

🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺

Thanks everyone!

Fixed on commit:

diff --git a/src/Plugin/Field/FieldFormatter/FieldPdfReaderField.php b/src/Plugin/Field/FieldFormatter/FieldPdfReaderField.php
index 682ed78..acb7d31 100644
--- a/src/Plugin/Field/FieldFormatter/FieldPdfReaderField.php
+++ b/src/Plugin/Field/FieldFormatter/FieldPdfReaderField.php
@@ -177,7 +177,7 @@ class FieldPdfReaderField extends FormatterBase {
     $toolbar = $this->getSetting('embed_hide_toolbar');
     $fragment = http_build_query([
       'view' => $fit,
-      'toolbar' => ($toolbar ? 0 : 1)
+      'toolbar' => ($toolbar ? 0 : 1),
     ]);
     foreach ($items as $delta => $item) {
       if ($values = $item->getValue('values')) {

Comment about 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Comments & Activities