[V2] Consider re-working CSS to play with off-canvas reset

Created on 31 October 2022, over 1 year ago
Updated 24 May 2024, about 1 month ago

Problem/Motivation

https://www.drupal.org/node/3305664 β†’ has landed in 10.0.x. As such, this module will likely require somewhat of a rewrite in order to work with the new off-canvas styles.

Proposed resolution

This may require a new major branch, or else supporting multiple artifacts depending on major Drupal version.

Can we perhaps simply wrap the recommended off-canvas targeting selector around the inclusion of the various SCSS files that apply to the off-canvas region in https://git.drupalcode.org/project/gin_lb/-/blob/1.0.x/styles/gin_lb.scss?

#drupal-off-canvas:not(.drupal-off-canvas-reset),
#drupal-off-canvas-wrapper {
  @import "components/..."
}

Remaining tasks

  • Wrap the CSS up and see what breaks.
  • Resolve visual regressions.
  • Hopefully not have to completely refactor things ever again?

User interface changes

None (hopefully!)

API changes

None

Data model changes

None

πŸ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States Luke.Leber Pennsylvania

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024