- π³π΄Norway steinmb
π Automated A11y tests in Nightwatch Fixed is now in, unblocking
- πΊπΈUnited States dmundra Eugene, OR
The header-order is caused by 'Your search yielded no results.' being an
Linking to some historical context of why that was the case:
* https://www.drupal.org/project/drupal/issues/1926344#comment-8256493 β , mentions the header issue with multiple
s and making 'Search results' an
.
* https://www.drupal.org/project/drupal/issues/1926344#comment-8418527 β , suggested dropping 'Search results' from being displayed if no results but leaving the
for 'Your search yielded no results'.
So the question is should we change 'Your search yielded no results' to
but does it need to be a header could it be a paragraph. The point was raised in https://www.drupal.org/project/drupal/issues/1926344#comment-8256063 β and the comment was valid to leave it a header because of the help text after it. Since the text has been removed maybe setting to a paragraph is fine now?
- πΊπΈUnited States dmundra Eugene, OR
I found the related issue discussing the header change https://www.drupal.org/project/drupal/issues/3182458 π Accessibility: skipped heading level on for search "no results" text Fixed
- πΊπΈUnited States dmundra Eugene, OR
I believe this one is the search block duplicate ID issue https://www.drupal.org/project/drupal/issues/1852090 π Cached forms can have duplicate HTML IDs, which disrupts accessible form labels Needs work