hook_ckeditor5_plugin_info_alter() implementations that add a plugin should not be allowed

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 8 months ago →
🇫🇷France vbouchet
Please find a patch doing so. New tests need to be created.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 8 months ago
30,480 pass
Status changed to Needs work 8 months ago8:33am 2 November 2023
Comment 8 months ago →
🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Looks great! 🤩

If you're interested, I think the best way to test this would be to extend \Drupal\Tests\ckeditor5\Kernel\CKEditor5PluginManagerTest::testInvalidPluginDefinitions(). That'd also require making \Drupal\Tests\ckeditor5\Kernel\CKEditor5PluginManagerTest::mockModuleInVfs() more capable. Would you be interested in doing that too, @vbouchet? 🤓
Comment 8 months ago →
🇫🇷France vbouchet
Can't promise any timing but I am always interested to follow my patches when I get reply and clear direction 😉.
Will try to have a look.

Comments & Activities