Fix warning of no validation date progress build of the achievements page

Created on 30 October 2022, over 2 years ago
Updated 21 June 2023, almost 2 years ago

Problem/Motivation

Having no validation date value.

Steps to reproduce

Given that I'm the webmaster for an Opigno site
When I go to a training statistics on a course for a selected user "group/COURCE_ID/training-statistic/USER_ID"
Then I get the warning of no validation date progress build of the achievements page

Warning: Undefined variable $validation_date in Drupal\opigno_learning_path\Progress->getProgressBuildAchievementsPage() (line 612 of modules/contrib/opigno_learning_path/src/Progress.php).
Drupal\opigno_learning_path\Progress->getProgressBuildAchievementsPage(41, 119, '') (Line: 216)
Drupal\opigno_learning_path\Progress->getProgressBuild(41, 119, '', 'achievements-page') (Line: 164)
Drupal\opigno_learning_path\Progress->getProgressAjaxContainer(41, 119, 0, 'achievements-page', 1) (Line: 924)
Drupal\opigno_learning_path\Controller\LearningPathAchievementController->build_training_summary(Object, Object) (Line: 944)
Drupal\opigno_learning_path\Controller\LearningPathAchievementController->build_training(Object, Object) (Line: 1052)
Drupal\opigno_learning_path\Controller\LearningPathAchievementController->Drupal\opigno_learning_path\Controller\{closure}(Object)
array_map(Object, Array) (Line: 1053)
Drupal\opigno_learning_path\Controller\LearningPathAchievementController->buildTrainingProgress(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 564)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 709)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Proposed resolution

Have a check for the $validation_date before passing it

Remaining tasks

  • File an issue
  • Fix patch/MR for the issue
  • Test
  • Review
  • Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A
🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024