SymlinkValidatorTest doesn't test PreApplyEvent

Created on 28 October 2022, over 1 year ago
Updated 20 January 2023, over 1 year ago

Problem/Motivation

Right now, SymlinkValidatorTest covers status checks and PreCreateEvent, but not PreApplyEvent.

There's a technical reason for this: namely, it is very tricky to change the behavior of the mocked precondition after the stage has been created, but before it's been applied. It could be done, of course, but would take significant refactoring of the test, and possibly the validator too.

This is not a big deal, because the validator behaves exactly the same way on PreCreateEvent and PreApplyEvent (and StatusCheckEvent, for that matter), and we are testing PreCreateEvent, so we can be pretty confident that PreApplyEvent works fine too. But it would still be nice to explicitly cover it. Therefore, this issue exists, but is a minor thing.

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

No activities found.

Production build 0.69.0 2024