MenuBasedBreadcrumbBuilder::addMissingCurrentPage() constructs an incomplete request

Created on 21 October 2022, over 2 years ago

Updated 28 March 2024, about 1 year ago

Problem/Motivation

The request passed to $this->titleResolver->getTitle() does not have enough attributes to cover some cases.
For example, if the _title_callback is EntityController::title(), it will not work is the request does not have an _entity attribute.

Steps to reproduce

Create a custom entity type which route uses EntityController::title() as _title_callback.
Add a menu based breadcrumb on this page.
The breadcrumb does not contain the current page.

Proposed resolution

The request should have the same attributes as the current request.

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇫🇷France prudloff Lille

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇳🇿New Zealand RoSk0 Wellington
This patch does fix the issue for us on 8.x-1.16 and Drupal 9.5 however on a bit different scenario, more like on the 🐛 Multiple contextual filters break expected breadcrumb structure RTBC .

I believe both of those should be committed as they are fixing different , but related problems.
Comment about 1 year ago →
🇳🇿New Zealand xurizaemon Ōtepoti, Aotearoa 🏝
@RoSk0 let's discuss this and 🐛 Multiple contextual filters break expected breadcrumb structure RTBC next week, we could get them landed.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024