- 🇺🇸United States owenbush Denver, CO
This change looks good and makes sense to me.
One thing I wonder is for inherited fields that append or prepend, this may be problematic. If the cardinality of the source field is 3, for example, and we set the cardinality of the inherited field to 3, then what happens with values appended/prepended?
There are a couple of approaches we could take:
1. Always just make them unlimited, to handle any combination of source+destination field cardinalities
2. Set to unlimited if source field or destination field are unlimited, otherwise source field cardinality + destination field cardinalityGiven that this has probably arisen from a use-case of yours, what approach do you think makes most sense to handle the possibility of appending/prepending values from the destination entity too?
- 🇺🇸United States owenbush Denver, CO
I've gone ahead and made some changes to better determine what the cardinality should be.
Inherited fields will just use the source field cardinality
Fallback fields will use the larger of the source field and destination field cardinalities, unless one of them is unlimited, in which case it will be unlimited.
Appended/Prepended fields will use the source cardinality + the destination field cardinality - unless one of them is unlimited, in which case it will be unlimited.