Improved support of required properties

Open on Drupal.org →

Created on 17 October 2022, about 2 years ago

Updated 3 October 2023, about 1 year ago

Problem/Motivation

When specifying pattern schema properties as required, the layout builder off canvas dialog form does not visually communicate which inputs are required (e.g. red asterisk as with Drupal field UI) nor is there any client side or server side required validation occurring.

Steps to reproduce

Create a pattern schema with required property, e.g. "required": ["text"] to the example schema.
Add pattern to a layout
Observe the class required added to the input's label element within the page source
Observe no visual required indicator
Save form without input
Observe no validation of missing required value

Proposed resolution

Add a theming rule for label.required to the Cygnet theme to add a visual indication for required fields.

Remaining tasks

TBD

User interface changes

TBD

API changes

TBD

Data model changes

TBD

✨ Feature request

Status

Fixed

Version

9.1

Component

Module Core

Created by

🇺🇸United States jasonawant New Orleans, USA

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

First commit to issue fork.
@christopherdoherty opened merge request.
Comment about 1 year ago →
🇮🇳India minsharm India
Retested the issue by adding "required": ["text"] to the schema file and applying the patch introduced in issues/3381549 🐛 JSON Editor theme assets do not load on Drupal 10.1 Fixed with merge_requests/76 for the below PK blocks on D9 as well as on D10 platform.

Result looks good to me.

PK Example

PK Example_Filtered

PK example_filtered_multiple

PK example_ref

Drupal 9

Required asterisk displays in off-canvas tray

Required asterisk displays in new tab.

Drupal 10

Required asterisk displays in off-canvas tray

Required asterisk displays in new tab.

Not getting any error that we were getting earlier at the time of PK block addition in new tab
Status changed to RTBC about 1 year ago3:32pm 3 October 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update about 1 year ago
359 pass
Comment about 1 year ago →
🇺🇸United States mariohernandez Los Angeles
slucero → credited mariohernandez → .
Comment about 1 year ago →
🇺🇸United States slucero Arkansas
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update about 1 year ago
359 pass
Comment about 1 year ago →
System Message

slucero → committed d3b14576 on 9.1.x authored by christopherdoherty →
Issue #3315794 by christopherdoherty, jasonawant, minsharm,...
Status changed to Fixed about 1 year ago3:46pm 3 October 2023
Comment about 1 year ago →
🇺🇸United States slucero Arkansas
Merged for inclusion in the Beta 8 release: 🌱 Patternkit Beta 8 Release Plan Active
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024