- Issue created by @krisahil
- @krisahil opened merge request.
- Status changed to Needs review
10 months ago 8:24pm 21 August 2023 - last update
10 months ago 356 pass - πΊπΈUnited States krisahil
Attaching a patch that works with both Drupal core 10.0 and 10.1. It's not a long-term fix, but might be a workable bridge, until we can refactor how we attach JSON Editor theme assets.
- πΊπΈUnited States slucero Arkansas
The patch looks good to me and I believe it is a good step forward for a near-term solution. For a more long-term solution to simplify the approach overall, I've documented a follow-up task in π Attach JSON Editor Theme Assets Using Library Attachments Postponed .
For next steps, we'll need to test this patch to make sure it work as expected for Drupal 9, Drupal 10.0, and Drupal 10.1+.
- πΊπΈUnited States jasonawant New Orleans, USA
Updated change records links in issue summary; unable to use issue formatting such as [#3301716], with non issue content.
Retested the issue with this Patch File on D 9.5.8 as well as on D 10.1.0 and Patternkit Editor loads successfully in the new window now.
Steps to test :
Enable Patternkit, Patternkit Example and layout builder module.
Go to content -> Add content. Select Basic Page.
Give the title of the page and click save.
Go to Layout Tab.
Click on Add block.
Right click on Patternkit example block and click on "Open link in new tab"Before Fix : Error message displays when attempting to add a new block/pattern in a new window or tab (outside of off-canvas tray).
After Fix (With Patch File) : Patternkit Editor loads successfully in the new window now.
Attaching screenshots.
-
krisahil β
authored f77b8f78 on 9.1.x
Issue #3381549 by krisahil, minsharm, jasonawant: JSON Editor theme...
-
krisahil β
authored f77b8f78 on 9.1.x
- Status changed to Fixed
9 months ago 6:12pm 25 September 2023 - πΊπΈUnited States slucero Arkansas
This has been merged for inclusion in the Beta 8 release. Thanks everybody!
Automatically closed - issue fixed for 2 weeks with no activity.