Plan for hCaptcha 8.x-1.3

I think it could be time to make a new release. We don't have 2 of the fixes here, but we do have Drupal 10 compatibility which feels worthwhile to release.

A couple days ago I had a quick look at the changes since 8.x-1.2 and noticed that the diff is considerable. I'm trying to get some time in the next few days to do a final check of the changes before tagging a new release.

Here's a review https://git.drupalcode.org/project/hcaptcha/-/compare/928840a75cbdf6223c...

If any more commits happen that link will not show them.

Most of the changes are superficial. I think the biggest functional change is #3248736: Add support for score-based verification → .

Found that the signature for RequestMethod::submit() (interface) doesn't match how Drupal8Post::submit() is implemented. Fixed in 🐛 RequestMethod/Drupal8Post: incompatible interface vs. implementation signature Fixed .

Did some minimal testing for now, but would like to test some more before cutting 1.3.

The changes introduced in 🐛 coding standards and best practices Closed: won't fix caused various errors:

• 🐛 RequestMethod/Drupal8Post: incompatible interface vs. implementation signature Fixed
• Fatal error: Cannot use isset() on the result of an expression (you can use "null !== expression" instead) in /var/www/html/src/web/modules/contrib/hcaptcha/hcaptcha.module on line 81 (found when running drush cr)
• Error: Call to a member function getCurrentRequest() on null in hcaptcha_captcha_validation() (line 84 of modules/contrib/hcaptcha/hcaptcha.module). (Found when rendering the hCaptcha widget in a Drupal Form)

It looks like those coding standards fixes were done without paying close attention; I'm not sure what's best at this point: revert that commit or try to fix? I'd prefer to revert, since that should guarantee we get back to a working state.

Forgot to say: thanks for the GitLab compare link, @greggles, it looks quite useful! I think I'll use it next time!

I tried reverting, but the work in #3347120 meant that a simple revert won't work. Luckily the conflict was quite small and I think I was able to resolve it.