Do not use loadByProperties

Created on 5 October 2022, over 2 years ago
Updated 29 March 2023, about 2 years ago

This module uses the loadByProperties() method, which is handy, but... it disables access checks.
The case I faced - I have the setup with a domain + domain_entity modules as I need to separate social login entities per domain.
Thes modules alters the queries to prevent entities from appearing on other domains, but it needs an "ENTITY_TYPE_ID_access" query tag, which is ignored by the usage of loadByProperties().

The contrib module should not decide on not using access checks for the queries, this should developers decision.

The suggested solution is to replace the loadByProperties with an entity query.

โœจ Feature request
Status

Fixed

Version

4.0

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ฆUkraine gilmord ๐Ÿ‡บ๐Ÿ‡ฆUkraine

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024