- 🇺🇸United States DamienMcKenna NH, USA
The patch doesn't include the MR's changes and seems like it's solving a different issue?
As a reminder, please set the "assigned" field back to "unassigned" when you're finished with an issue. Thank you.
- Assigned to kbk1992
- Issue was unassigned.
- 🇮🇳India anweshasinha
Hi,
Added patch for the issue according to php 8.1.22 standard. Please review the patch - last update
10 months ago 48 pass - Status changed to Needs review
10 months ago 8:01am 11 September 2023 - last update
10 months ago 48 pass - last update
10 months ago Patch Failed to Apply - 🇺🇸United States DamienMcKenna NH, USA
For completeness sake, #12 would exclude certain characters from being allowed, e.g. a zero or a space. While, in practical terms I suspect these exceptions should be allowed (who would use "0" or a space as a separator in their URLs anyway?), I think it might be best to make sure the string is being vetted the same as the separator form field itself.
- Status changed to Needs work
9 months ago 2:20pm 8 October 2023 - 🇨🇭Switzerland Berdir Switzerland
Yes, seems like the MR is the best solution for this.
Per #3, this should only happen if you have incomplete settings, I've fixed some issues that caused fatal errors and prevented users from even changing the settings, but that's not the case here. Resaving the settings form should IMHO get rid of this problem.
The MR can't be rebased through the UI it seems, please do that manually.
!empty($string)isn't a correct way to check for a string's emptiness.empty('0') === TRUE