Diff should typehint DateFormatter interface rather than a specific implementation

Created on 4 October 2022, over 1 year ago

Updated 25 April 2024, 2 months ago

Problem/Motivation

Various classes typehint the injected date.formatter service with the default implementation rather than the interface.This leads to problem like when modules try to decorate or override the service.

Steps to reproduce

Decorate or replace date.formatter with a different class.

Proposed resolution

Typehint constructor with interface, not concrete implementation.

User interface changes

Nil

API changes

Nil

Data model changes

Nil

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇦🇺Australia dpi Perth, Australia

Live updates comments and jobs are added and updated live.

Incomplete comments

Merge Requests

!24Diff should typehint DateFormatter interface rather than a specific implementation
Merged
🇦🇺Australia dpi
updated 3 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Merge request !24Issue #3313385: Diff should typehint DateFormatter interface rather than a specific implementation → (Merged) created by dpi
Comment 12 months ago →
🇦🇺Australia acbramley
Any chance of getting this committed?
Pipeline finished with Skipped
3 months ago
#143501
Comment 3 months ago →
System Message

acbramley → committed 077bdf2c on 8.x-1.x authored by dpi →
Issue #3313385 by dpi, acbramley: Diff should typehint DateFormatter...
Status changed to Fixed 3 months ago5:08am 11 April 2024
Comment 3 months ago →
🇦🇺Australia acbramley
Comment 2 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024