Allow the database query log to be dispatched as log events

Adding the ID of the StatementInterface object as returned by spl_object_id() is to me a good idea.
There is testing added for the extra functionality.
Back to RTBC.

Wow this is amazing, thanks for running w/ this feature request! I'm now able to monitor db queries as they execute and build a nice hierarchical view of operations - see attached screenshot. I noticed that database logging didn't work until I cleared caches (not really a problem, just saying).

Added a little release note snippet, feel free to edit.

#35 nice!

#35 looks exciting! Adding tags for release notes + highlights. Haven't reviewed this enough to be able to commit it yet. What I did review didn't raise any massive flags - don't see a way around the \Drupal:: calls, and making it conditional on events being enabled at all is a good plan.

Rerolled.

This will also be useful for 🌱 Automated performance testing for core Active , not that it's anywhere close but I've started working on it again after a decade.

Reviewed again and couldn't find anything to complain about. Going to untag for release notes because there's nothing really for site owners here, but we can leave it tagged for highlights as an API improvement - can always drop it later.

Committed d7313cc and pushed to 10.1.x. Thanks!

mondrake → closed merge request !3137

Created 📌 Create span for database execution Fixed for OpenTelemetry.

Filed ✨ Add transaction-related events to the Database API Needs work for follow-up.

Is enabling logging the only way to automatically enable events on all new connections? (If so, ideally we could make it easier to enable events without logging.)

Database::openConnection() has

    if (!empty(self::$logs[$key])) {
      $new_connection->enableEvents([
        StatementExecutionStartEvent::class,
        StatementExecutionEndEvent::class,
      ]); 

Btw, I noticed a typo in the change record which I'll fix:

Calling code needs to opt-in for event dispatching by calling ::enableStatementEvents(TRUE) on the database Connection object.

should be

Calling code needs to opt-in for event dispatching by calling ::enableEvents(TRUE) on the database Connection object.

Automatically closed - issue fixed for 2 weeks with no activity.