Make Dropzone fully optional

Created on 21 September 2022, over 2 years ago

Updated 5 April 2023, about 2 years ago

Problem/Motivation

Turned out that the module is fully functional without Dropzone. More to it, Dropzone support is already implemented in the sub-module, media_bulk_upload_dropzonejs.

It looks to me that this commit accidentally introduced, re-introduced , dependency on Dropzone module and this issue should probably be a bug report, but I will leave this to maintainers.

Most important part is that I can use this module with Dropzone, but the module will be added by Composer because it's listed as dependency.

Proposed resolution

Remove dependency from composer.json, e.g.

  "require": {
    "drupal/dropzonejs": "^2.0"
  }

Update the README.md file, e.g.

   It uses [DropzoneJS](http://www.drupal.org/project/dropzonejs) to quickly upload multiple files.

and

  1. Download this module, and [DropzoneJS](http://www.drupal.org/project/dropzonejs).

Update install hook to be smarter and only install for previous versions, e.g.

  /**
   * Enable dropzonejs integration submodule.
   */
  function media_bulk_upload_update_8001() {
    $modules = array(
      'media_bulk_upload_dropzonejs',
    );
    Drupal::service('module_installer')->install($modules);
  }

Update project page to make it clear that Dropzone is a optional improvement to the UI

📌 Task

Status

Active

Version

3.0

Component

Code

Created by

🇳🇿New Zealand RoSk0 Wellington

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Updated the summary to add more items to the proposed resolution (README.md and install hook).

Obviously, bulk upload would need to be properly tested without the media_bulk_upload_dropzonejs module enabled to make sure it still works.
Comment almost 2 years ago →
🇳🇿New Zealand RoSk0 Wellington
It works great. We have tests covering this functionality as was reported in 🐛 Impossible to submit a form without JavaScript on Drupal 9.5 Active .

Also it's clearly not only us using this module without DropzoneJS, according to 🐛 Can not upload using core file upload element (no dropzonejs) because of false validation errors RTBC .
Assigned to Kristen Pol
Comment about 2 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Perhaps this can be done at the same time as updating the codebase to D11.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024