The save configuration button combines the functionality of saving configuration in addition to posting the CORS update to the backend provider. This can cause problems when you are overriding the configuration values in settings.
Provide a configuration override for e.g. the CORS origin in your settings.php, such as:
$config['s3fs_cors.settings']['s3fs_cors_origin'] = 'override.example.com';
In the admin ui, click save settings, and any value entered in the configuration page (e.g. default.example) will be used, instead of the override value from settings. Additionally, any issue applying the settings is not being handled.
Nothing external - all changes are in configuration form.
None, though note this is explicitly (in part) to ensure the configuration data can be overridden successfully.
Needs review
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
The tests don't get run on patches. Can we update the MR so we can see what the testbot says?
Updated tests and fixed some of the linting errors, except for the eslint ones which I don't think are relevant to the changes here.