- πΊπΈUnited States patrickfweston Columbus, Ohio
This would be really great to get merged in. I've created a patch for our project to provide URLs with
itok
values for images with styles. We were seeing that the image styles were not getting cleared in cache.The approach in this branch using wildcards is a much better solution.
I've included my patch if folks are curious. However, when I get time, I'll be switching our codebase over to the wildcard approach.
- Status changed to RTBC
over 1 year ago 10:48am 22 May 2023 - πͺπΈSpain omarlopesino
Hi. Apologies for the late response. Many thanks for the MR of DaleTrexel and the image styles patch provided by patrickfweston.
I think the first solution provided is good and will also cover the caching of image styles. So I will focus on review and integrating this MR.
I need to review this manually to confirm it works okay. If someone has tested the merge request, please mark it as RTBC.
- Status changed to Needs review
over 1 year ago 10:50am 22 May 2023 -
Bryan Toapanta β
committed b810ffa1 on 1.0.x authored by
DaleTrexel β
Issue #3308665: Include Query String Variants in Purge Request
-
Bryan Toapanta β
committed b810ffa1 on 1.0.x authored by
DaleTrexel β
- πͺπΈSpain Bryan Toapanta
This correction will be ready in the 1.1.0 version. Thanks for the contribution!
- Status changed to Fixed
over 1 year ago 12:46pm 22 May 2023 - πΊπΈUnited States daletrexel Minnesota, USA
Thanks to everyone who helped move this along!
Automatically closed - issue fixed for 2 weeks with no activity.