Password Character Length Policy allows duplicate and invalid

Assigning to myself as I'm reviewing/merging ready RTBC fixes/updates over the next few days.

This is working as expected. Note that if you already had constraints added, it doesn't check those when saving. This is only relevant for new policies.

Thanks for the work on this issue. This is a nice little UX improvement.

Reviewing the code:

1. This is misspelled: $constaint

2. This shouldn't be inside the loop since it doesn't change:

+        $new_operation = $form_state->getValue('character_operation');
+        $new_length = $form_state->getValue('character_length');

3. And, since there are other changes, I think these two variable names should change:

* Change $other_operation to $constraint_operation
* Change $other_length to $constraint_length

Added patch please review.

Assigning to myself to review, and changing this to 4.0.0.

Thanks everyone. I improved the messages a bit. Merged and will be in the next release.

Automatically closed - issue fixed for 2 weeks with no activity.

This is part of the new 4.0.1 release → .