WSOD on User Fields Mapping module

Created on 7 September 2022, over 2 years ago
Updated 26 July 2023, over 1 year ago

Problem/Motivation

A WSOD appears when enabling the submodule User Fields Mapping

Steps to reproduce

Running the submodule 8.x-3.8 version on Drupal 9.4.5 with PHP 8.1.8

Proposed resolution

There appears to be a typo on line 58 of samlauth/modules/samlauth_user_fields/src/Form/SamlauthMappingListForm.php. The line ends in a period instead of a comma. It reads:

  • $container->get('entity_field.manager').

but should read:

  • $container->get('entity_field.manager'),
πŸ› Bug report
Status

Fixed

Version

3.8

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States phpforfree

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States Douglas Marsh

    What is preventing this fix merged into a new release?

    --Doug

  • πŸ‡³πŸ‡±Netherlands roderik Amsterdam,NL / Budapest,HU

    1. Work/personal time intermixed stuff (this module is unpaid/volunteer work from my side vs. free time vs. other volunteer projects that are running out vs. currently the need to concentrate on trying to get some paid work again, hopefully Drupal related)

    2. My tingling sense that this is not the last bug remaining but that there's a D10 compatibility issue hidden in an event subscriber (to be more exact: class naming that isn't correct anymore for the new Symfony version) that was never addressed

    (Yes, this module should get real test coverage to prevent stuff like this. That would take a lot of effort.)

    3. Stubbornness from my side; not wanting to continue a string of rushed releases that I do not personally know are really D10 compatible.

    I know it's getting ridiculous because it's been over a year. (Last time I really looked at this module was June 2022 / D9-only v3.5).

    Tell me if you can't live with patches. Otherwise: likely ~12-14 days from now.

    [ Linking other/duplicate issue ]

  • Status changed to Fixed over 1 year ago
  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί
  • πŸ‡³πŸ‡±Netherlands roderik Amsterdam,NL / Budapest,HU

    Urgh: this was caused by the confusing D10 upgrade pushed out in v8.x-3.7.

    And the other thing "hidden in an event subscriber" which I mentioned, does not need work. (It was already fixed / the changed Symfony class name was already compatible from D9.2+.)

    Oh well. I finally have a well working local development environment (which is a must with this module), and I plan to work more on issues soonish. But first, a release that contains this fix.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024