Filtering only by All does not return anything

Created on 2 September 2022, about 2 years ago
Updated 12 March 2024, 8 months ago

Problem/Motivation

When using the webform_workflows_element_state views filter, filtering only by All returns nothing.

Steps to reproduce

1. Create a workflow.
2. Create a webform using the workflow created in Step 1.
3. Create a bunch of submissions for the form created in Step 2.
4. Create a View of the submissions in Step 3.
5. Add a webform_workflows_element_state filter to the View.
6. Filter by "All".

The status filter is an "IN" filter but All's value is an empty string, effectively saying "find all submissions with status IN ['']" which will return nothing. Selecting All should return all submissions, as if the filter was never applied.

Proposed resolution

Have the plugin not add the query alterations when only All is selected.

Remaining tasks

- Patch
- Review
- Merge

User interface changes

None

API changes

None

Data model changes

None

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States fskreuz

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024