- @heddn opened merge request.
- Status changed to Needs review
over 1 year ago 10:03pm 21 March 2023 - heddn Nicaragua
This adds tests and responds to the feedback on the MR. Since I didn't have access on the original MR to change its base, I've opened a new on that is set to merge into 10.1.x.
- Status changed to RTBC
over 1 year ago 1:09am 22 March 2023 - πΊπΈUnited States mherchel Gainesville, FL, US
Verified that the MR in #14 resolves the issue. I tested both eager and lazy loading, and the patch works as expected.
I'm attaching the test as a patch to ensure that it fails properly. Assuming that the patch containing the tests fail, this is RTBC.
I also hope we can backport this to 9.5.x, as this is a but that'll likely affect a number of sites.
The last submitted patch, 16: 3307409-16-TEST-ONLY-FAIL.patch, failed testing. View results β
- πΊπΈUnited States mherchel Gainesville, FL, US
Test only patch failed! RTBC!
The last submitted patch, 16: 3307409-16-TEST-ONLY-FAIL.patch, failed testing. View results β
- Status changed to Fixed
over 1 year ago 2:47pm 24 March 2023 - πΊπΈUnited States mherchel Gainesville, FL, US
yay!
@catch: would it be appropriate to also backport this to 9.5.x and 10.0.x?
This is something that I've run into several times in my projects :D
- π¬π§United Kingdom catch
We could but it would be nice to get 10.0 and 9.5 test runs.
- πΊπΈUnited States mherchel Gainesville, FL, US
Makes sense!
Patches are attached. Note this is the exact same patch as the commit in #21
- Status changed to RTBC
over 1 year ago 6:44pm 26 March 2023 - πΊπΈUnited States mherchel Gainesville, FL, US
We could but it would be nice to get 10.0 and 9.5 test runs.
Test runs completed. Setting to RTBC so it doesn't slip through the cracks. Thanks!
- Status changed to Fixed
over 1 year ago 12:05am 28 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.