npm install fails if not using node 12 or 14 (as per foundation requirements)

Created on 17 August 2022, almost 2 years ago
Updated 10 April 2023, about 1 year ago

I created a subtheme of Zurb Foundation based on the STARTER directory as specified in the documentation (manual installation, since the Drush procedure does not work with Drush 9). When I run `npm install`, I get errors (see attached log).

This looks like #3010079: NPM error during install (Update to foundation-sites 6.5.0) β†’ , only that my version of package.json is much more recent than the patched version in this issue...

I am afraid I will not be able to use this subtheme until a solution to this issue can be found...

npm 8.11.0 (also tried 8.17)
node 16.16.0
Run inside a DDEV web container.

πŸ“Œ Task
Status

Active

Version

6.0

Component

Documentation

Created by

πŸ‡«πŸ‡·France FMB PerpinyΓ , Catalonia, EU

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States Macronomicus

    I noticed same, even with reverting that package, which is undesirable, there's many other warnings from npm including high & critical security stuff. & gulp watch still isnt working for me either.

    Im guessing we need a whole new package.json for this theme given how much has changed since written?
    Im testing with project/zurb_foundation 9.0.0-beta1

    Im going thru doing npm updates but there's many, a few have broken sub contained dependencies themselves such as gonzales-pe-sl and its issue with requiring the outdated minimist that has security issues. There's a patch for it, but its not yet applied.
    https://github.com/ben-b-ow/gonzales-pe/tree/upgrade-minimist

    I've got this theme up & running in my dev, and like it a lot, it looks great to work with structure wise, just no love yet with using its localdev tooling, gulp etc.

  • πŸ‡ΊπŸ‡ΈUnited States Macronomicus

    @erutan
    I didnt change much on the gulp file.
    Im not sure how many npm updates I did but I went thru all the warnings & resolved the most pressing warnings but not everything since I just wanted to get it working I kept updating until things worked.

    I attached a diff patch for the gulpfile.babel.js, you'd need to use different paths of course or just hand edit your sub themes file, and I guess just go thru enough npm updates until you're happy & things work. It could be that I did updates with npm that caused me to need to update the format on the gulpfile.babel.js, but I cant recall exactly which update required those changes, likely gulp-sass related since that wasnt working for me.

  • πŸ‡ΊπŸ‡ΈUnited States Macronomicus

    Oops the patch was backwards lol... sorry

  • πŸ‡ΊπŸ‡ΈUnited States erutan

    Thanks for that.

    My package.json built file by just bumping node-sass to 7.0.0 as per the package.json on the zurb-template repo - I don't care about warnings since this is only going to be run on localdev and not on a server, all it has to do is build. watch is just built into the main gulp script now, running $ gulp.

    I bumped up foundation-sites to 6.7.5 (should we just put it and motion-ui at "latest"?). Watch and start can just be taken out of the scripts section of package.json.

    I've taken some notes as I've been porting over my old 8.6x-dev child theme to the new STARTERKIT and will share when I'm done with this process, have to run at the moment!

  • πŸ‡ΊπŸ‡ΈUnited States erutan

    The 9.0 issue has been solved here, and the initial 8.6 prompt is more of a docs issue https://www.drupal.org/project/zurb_foundation/issues/3348930 πŸ› Update STARTER package.json so gulp runs, cleanup some extra cruft Closed: won't fix

  • πŸ‡ΊπŸ‡ΈUnited States erutan

    Edited the issue title to be more self-explanatory :)

  • πŸ‡ΊπŸ‡ΈUnited States Macronomicus

    Glad you got it sorted, its working nicely for me. Im enjoying building with Zurb & latest drupal, this is my first Zurb theme.

    The foundation DROWL mods & setup also here on d.o goes nicely with this theme, since they're extending drupal with foundation in mind, & paragraphs layouts etc etc.

  • πŸ‡ΊπŸ‡ΈUnited States erutan

    I wasn't familiar with https://www.drupal.org/project/drowl_layouts β†’ does it work with paragraphs better than https://www.drupal.org/project/foundation_layouts β†’ ? I do notice that it explicitly mentions paragraphs where foundation_layouts is more traditional layout vs content like ds & panels. It might be worth mentioning on the project page if so.

    I really like how Foundation has so many variables but is somewhat bland - it's useful out of the box without being opinionated and really easy to turn into your own thing while still having a really solid, erm, foundation. :)

  • πŸ‡ΊπŸ‡ΈUnited States Macronomicus

    Im just testing things to see, Ive tended towards bootstrap for sites, but I like foundation now too. With drowl im also just testing, there's a lot they've done, several modules that integrate for a full setup, there's even a theme they're working on too thats a subtheme of zurb_foundation, but its not on d.o its on gitlab. I've not tried all of their modules yet but so far looks interesting, only one has dependencies that cannot be met, I think because missing configs not published, that, or ive not found them yet.

  • πŸ‡ΊπŸ‡ΈUnited States erutan

    Interesting, yeah they plan to bring their theme public and integrate it with their suite of modules. from https://www.drupal.org/project/drowl_paragraphs β†’ "Important note: In the current state you need to do a lot of manual configuration to bring all the functionality to life. It was designed to work perfectly with our custom theme. Stay tuned for the upcoming releases - we will make it work more "out of the box"."

    The code for their base theme is at https://gitlab.com/webksde-public/drupal/drowl-base-theme, but I imagine it's still being abstracted out of what they're currently using for client work.

Production build 0.69.0 2024