Do not assume that Composer package names will exactly match Drupal projects names

This is still relevant. And given 📌 Looking for Alpha tester for future functionality Active , we should probably get this done soonish.

The successor to getProjectForPackage() is \Drupal\package_manager\InstalledPackage::getProjectName().

This needs to be rebased on top of 3.0.x.

i'm wondering if the project name changes are even required now ?

AFAICT the test coverage in the old MR has not yet been ported to the new MR? 😅

Also, in reviewing the kinda tricky changes to getProjectTitle(), I discovered that it's essentially obsolete now and can be replaced with a trivial single line.

Wim Leers → closed merge request !480

The tests in the Old MR are obsolete now so the main problem described in the issue was the assumptions about how the project name and package name were related and with the new methods (\Drupal\package_manager\InstalledPackagesList::getPackageByDrupalProjectName and \Drupal\package_manager\InstalledPackage::getProjectName) it's no more the case and it has it's own coverage in \Drupal\Tests\package_manager\Kernel\InstalledPackagesListTest

From MR comments sounds like it needs tests

Updated the issue summary to explain testing, and quoting comment #54

The tests in the Old MR are obsolete now so the main problem described in the issue was the assumptions about how the project name and package name were related and with the new methods (\Drupal\package_manager\InstalledPackagesList::getPackageByDrupalProjectName and \Drupal\package_manager\InstalledPackage::getProjectName) it's no more the case and it has it's own coverage in \Drupal\Tests\package_manager\Kernel\InstalledPackagesListTest and the project titles has tests too \Drupal\Tests\automatic_updates_extensions\Functional\DisplayUpdatesTest::testDisplayUpdates

📌 Add new InstalledPackagesList which does not rely on Composer API to get package info Fixed landed February 21, 2023.

This issue was opened in August 2022, and the old MR was worked on in Sep-Nov 2022. So yeah, things have obviously changed 😅+1 for #58.

But the MR is still wrong it seems? private function getProjectTitle(string $package_name): string { is first removed and then restored. I offered a much simpler alternative at https://git.drupalcode.org/project/automatic_updates/-/merge_requests/91... that still has not been addressed?

I did leave a MR comment https://git.drupalcode.org/project/automatic_updates/-/merge_requests/91... on that.

Wow, great catch, and clear explanation! 👍

This is then essentially ready … but since we're modifying this code anyway, we should be moving it to the appropriate location now.

I just cleaned up some things and added some test coverage by making on of the packages added in \Drupal\Tests\automatic_updates_extensions\Functional\UpdaterFormTestBase::setUp you a package that does not match the project name. Allo the function tests using this now pass, so I am going to RTBC this

Automatically closed - issue fixed for 2 weeks with no activity.