Wingsuit lb - Plugin icons are not customizable

Created on 12 August 2022, over 2 years ago
Updated 3 February 2023, almost 2 years ago

Problem/Motivation

At the moment, wingsuit_lb_preprocess_wingsuit_lb_icon always returns the empty icon.
This is because LayoutBuilderBrowserEventSubscriber does not provide the plugin id, so there is no way to differentiate the plugins.

Steps to reproduce

Add a section in the layout builder.

Proposed resolution

LayoutBuilderBrowserEventSubscriber should return the plugin id so that it can be used in HOOK_preprocess_wingsuit_lb_icon.

Remaining tasks

Do the same for the blocks.

User interface changes

None

API changes

None

Data model changes

wingsuit_lb_theme now has a plugin_id variable

📌 Task
Status

Fixed

Component

Code

Created by

🇨🇦Canada franknoel

Live updates comments and jobs are added and updated live.
  • Quick fix

    Very small and simple change. Preferred over Quickfix.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Fixed almost 2 years ago
  • Status changed to Fixed almost 2 years ago
  • 🇨🇦Canada franknoel

    For some reason, my code was removed after being merged. As far as I know, it is impossible to customize the section icon unless the plugin_id is available.

  • 🇩🇪Germany Christian.wiedemann

    Sorry was my fault.A merge error. Updated wingsuit.

Production build 0.71.5 2024