- Merge request !3Issue #3303430: Number sign symbol (#) in event title breaks ics download β (Merged) created by mmarler
- πΊπΈUnited States mark_fullmer Tucson
I've attached a patch that puts the title, location, and description -- the 3 fields that currently accept direct user input or tokens from the entity -- through
rawurlencode
, only for the iCal and Outlook outputs. The Google link should *not* be encoded in this fashion.The goal here is to ensure that any user input that contains characters that would cause the iCal content to be truncated, such as #, would be encoded. I tried to find something in the iCal spec about this but came up empty-handed.
1. I did confirm that both the Outlook and iCal outputs pass validation at https://icalendar.org/validator.html
2. I confirmed that the outputs could be imported into Outlook (MacOS) and "Calendar" (MacOS), as shown in the screenshots below:Setting this to needs review for input from others, especially mandclu, for corroboration that we should urlencode all three of these fields, that it should have no adverse effects on existing content (or any content, for that matter), and potentially to functionally test this on a Windows machine.
- last update
over 1 year ago 1 pass - πΊπΈUnited States mark_fullmer Tucson
I've put the latest proposed approach for handling this into the merge request, and targeting the 1.1.x branch now. Leaving as "Needs review."
-
mark_fullmer β
committed e42a01d9 on 1.1.x authored by
mmarler β
Issue #3303430 by mark_fullmer: Number sign symbol (#) in event title...
-
mark_fullmer β
committed e42a01d9 on 1.1.x authored by
mmarler β
- Status changed to Fixed
about 1 year ago 7:29pm 26 January 2024 - πΊπΈUnited States mark_fullmer Tucson
After further thinking about this, I conclude that the truncation due to the presence of a # symbol is a significant -- and not user-intuitive -- problem, and we should proceed with encoding the output to avoid this problem.
I've committed the merge request, which includes new test coverage.
Automatically closed - issue fixed for 2 weeks with no activity.