- 🇩🇪Germany sunlix Wesel
Finished some refactoring and solving the
phpstan,phpcshints.
eslint>is the only one with some complainings but from my point of view this looks like a false-positive from eslint.
These are all multilinequerySelectorcalls and for me it makes no sense to a comma at the end of the parameter list, because there is no further parameters to be set.Maybe @Grevil and @Anybody has a opinion on that?
/builds/project/etracker/web/modules/custom/etracker/js/etracker.admin.js 19:59 error Insert `,` prettier/prettier 47:62 error Insert `,` prettier/prettier 58:54 error Insert `,` prettier/prettier 74:80 error Insert `,` prettier/prettier 81:90 error Insert `,` prettier/prettier /builds/project/etracker/web/modules/custom/etracker/js/etracker.js 61:75 error Insert `,` prettier/prettier - 🇩🇪Germany sunlix Wesel
I did a manual test on the admin-js. The
cookiesrelated is covered by the fantastic functional test suite from @Grevil.
So I think this should be good. But we can leave it here for feedback from @Grevil.If I lint the silly string in to one line eslint want to make it multiline because of the line length. :D
The only one we can do is to introduce constants for the long selectors. - 🇩🇪Germany sunlix Wesel
I added that last trailing comma because I wanted to see the test green.
It feels unusual for me. But it is allowed: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Traili...I will find my way dealing with this :D
Ready for a merge if no one disagree. :)
- 🇩🇪Germany Anybody Porta Westfalica
Great! Yes I think a new release is fine.
Automatically closed - issue fixed for 2 weeks with no activity.