commerceguys/addressing 1.4 compatibility

Created on 8 August 2022, over 2 years ago
Updated 23 June 2023, over 1 year ago

The commerceguys/addressing has added some PHP 7.3 compatible type hints in the current 1.4.0 version, affecting some class overrides of the address module:

https://github.com/commerceguys/addressing/commit/c81ded457fa0cc7d2c9f5b...

This leads to errors like this:

PHP Fatal error: Declaration of Drupal\address\Repository\AddressFormatRepository::processDefinition($countryCode, array $definition) must be compatible with CommerceGuys\Addressing\AddressFormat\AddressFormatRepository::processDefinition(string $countryCode, array $definition): array in /app/web/modules/contrib/address/src/Repository/AddressFormatRepository.php on line 38

should be sufficient to search the code base for "extends External" and have a look at those implementations. I'm lacking time this evening unfortunately - otherwise I'd provide a patch

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇦🇹Austria agoradesign

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024