- 🇩🇪Germany Anybody Porta Westfalica
Fixed by @jfeltkamp in 2.x - please help testing 2.0.0-alpha1!!
Automatically closed - issue fixed for 2 weeks with no activity.
Based on the discussion in
#3301609: JS has hard dependency of cookies/cookiesjsr causes double load of cookiesjsr-preloader →
I think we should remove the additional cookies/cookiesjsr.cdn library and instead use cookies/cookiesjsr as only library definition for cookiesjsr.
With a hook_library_info_alter we should change the source, if CDN is enabled.
Why?
At first glance this sounds a bit weird, but I think it's an antipattern to use different libraries for the same "library" depending on the source. As library dependencies are kind of "API" which other modules can depend on, they would otherwise have to duplicate the logic for CDN / local switch.
Anyway this is minor, as typically COOKiES submodules and extending modules don't have to have a dependency on cookiesjsr if they call none of the cookiesjsr API functions. Only reacting to an event doesn't require a dependency in code. Nothing breaks, if the event isn't called!
That also turned out in the linked issue.
hook_library_info_alter to change the source of cookies/cookiesjsr for CDNcookies/cookiesjsr.cdnNone
Fixed
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Fixed by @jfeltkamp in 2.x - please help testing 2.0.0-alpha1!!
Automatically closed - issue fixed for 2 weeks with no activity.