Add groups claim

My apologies, but I'm just getting my feet wet with Drupal module development and this is my first attempt at a patch. Therefore, I'm not surprised that it has issues so can you consider this a feature request with the patch being a proof-of-concept?

And sorry for the lengthy delay in responding.

Re: #6
I'm not sure it makes sense to populate $userinfo['groups'] in \Drupal\openid_connect\Plugin\OpenIDConnectClientInterface::retrieveUserInfo.
The point is that the claim "groups" may be populated but with other info related to other stuff, while the info to do the roles mapping may be in another claim, for example 'entitlements' or 'roles' (yes, that's a standard OIDC claim too!). It all depends on the IdP configuration.

I developed a patch that allows to set which claim you want to use for the mapping, or none to skip the mapping, but it's for versin 3.x. I don't know how to proceed: should I open a different ticket?

@pbattino, any chance to add your patch? We're also using 3.x (with D10.0.10).

OK, I'll dig it out then. But my question stands: do I need to open a different ticket, since my patch is for 3.x ? (I'm not very familiar with issues spanning different versions developed in parallel.)

@pbattino,
For your 3.x patch just rename it like this: 3x-3300283-12.patch
branch-issue_number-comment.patch

or , if you prefer merge requests, you can make your own branch by following the instructions that follow from the green "Create an issue fork" button.

OK, I see now than when I upload I can select which version I want to test against. Let's see what happens.
Thanks @joseph.olstad

@pbattino, there's a couple errors in the tests.

loadByProperties on null

I'm uploading a slightly different version

try again

Back to patch 13

patch #13 has this error:

Expectation failed for method name is "getStorage" when invoked at least once

Haven't had enough coffee this morning yet.

Check this later

Is it possible that it is a problem of defaults?, i.e. the update hook works if you already have one Generic Client enabled, If you don't, it fails.

sorry I changed back the version to 2 by mistake.

OK the comment #18 is probably a red herring. Unfortunately I'm not able to run local test right now so I can't debug this.