Change Navbar Brand component to work with storybook and add its story

Created on 27 July 2022, over 2 years ago
Updated 30 May 2023, over 1 year ago

Problem/Motivation

  • Navbar branding rendered by block--system-branding-block.html.twig template, it needs a little bit change to make it more readable and understandable.
  • Height used in component but not defined in the template.
  • Navbar brand component needs to restructure to make it usable with storybook.

Proposed resolution

  • Change image key in template block--system-branding-block.html.twig to image_path.
  • Add height to component include in branding template, to use it properly.
  • Restructure navbar-brand component and put it with its all related files in sub directoy inside navbar.
  • Add navbar-brand.stories.js file.
  • Add navbar-brand.config.yml file.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-alpha1 , vartheme_bs5-2.0.0-alpha1

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇯🇴Jordan Abdullah Yassin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024