Replace margin bottom with padding bottom on header in page.twig

Created on 27 July 2022, almost 2 years ago
Updated 30 May 2023, about 1 year ago

Problem/Motivation

Header tag has a margin-bottom class mb-3 to make a space between header region and page content.
This margin causes a space between Navbar and the Main content on the home page.
And it's related to another unnecessary margin on the Heroslider media section, see Issue πŸ“Œ Remove margin top n5 from default content for the hero slider media on home page Fixed .

Proposed resolution

  • Add a preprocess on region to check if the page is front or not, and return true | false
  • Replace margin with padding by add pb-3 instead of mb-3, and make it added conditionally only if the page is not front.

Remaining tasks

  • βœ… File an issue about this project
  • βœ… Addition/Change/Update/Fix to this project
  • βœ… Testing to ensure no regression
  • βž– Automated unit/functional testing coverage
  • βž– Developer Documentation support on feature change/addition
  • βž– User Guide Documentation support on feature change/addition
  • βž– Accessibility and Readability
  • βœ… Code review from 1 Varbase core team member
  • βœ… Full testing and approval
  • βœ… Credit contributors
  • βœ… Review with the product owner
  • βœ… Update Release Notes and Update Helper on new feature change/addition
  • βœ… Release varbase-10.0.0-alpha1 β†’ , vartheme_bs5-2.0.0-alpha1 β†’

Varbase update type

  • βœ… No Update
  • βž– Optional Update
  • βž– Forced Update
  • βž– Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

πŸ› Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡―πŸ‡΄Jordan Abdullah Yassin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024