Replace margin bottom with padding bottom on header in page.twig

Created on 27 July 2022, over 2 years ago
Updated 30 May 2023, over 1 year ago

Problem/Motivation

Header tag has a margin-bottom class mb-3 to make a space between header region and page content.
This margin causes a space between Navbar and the Main content on the home page.
And it's related to another unnecessary margin on the Heroslider media section, see Issue 📌 Remove margin top n5 from default content for the hero slider media on home page Fixed .

Proposed resolution

  • Add a preprocess on region to check if the page is front or not, and return true | false
  • Replace margin with padding by add pb-3 instead of mb-3, and make it added conditionally only if the page is not front.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-alpha1 , vartheme_bs5-2.0.0-alpha1

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇯🇴Jordan Abdullah Yassin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024