- First commit to issue fork.
- last update
over 1 year ago run-tests.sh fatal error - @jhedstrom opened merge request.
- Status changed to RTBC
over 1 year ago 8:57pm 17 April 2023 - πΊπΈUnited States kreynen
Testing is failing with...
PHP Fatal error: Access level to Drupal\Tests\webform_pardot\Functional\ConfigurationTest::$modules must be public (as in class Drupal\Tests\webform\Functional\WebformBrowserTestBase) in /var/www/html/modules/contrib/webform_pardot/tests/src/Functional/ConfigurationTest.php on line 14
I found a few related/similar issues in other projects, but I haven't dug into what's actually happening or how it was fixed yet.
#3231016: Access level must be protected β
#3223667: Testing modules property Access Level β
#3145078: Possibly wrong use of $modules array in setUp() for functional tests. β specifically, https://www.drupal.org/project/metatag/issues/3145078#comment-13669740 β - Status changed to Needs work
over 1 year ago 10:06pm 17 April 2023 - πΊπΈUnited States kreynen
I think we're just chasing https://git.drupalcode.org/project/webform/-/commit/fff74893de8a6e2b14d2..., but I'm not sure the same test are going to run on D10 and D9. As D9 is nearing EoL and this project only has < 100 installs, I'm just going to update the testing to run only with Webform 6.x on D10.
- last update
over 1 year ago 2 pass, 3 fail - last update
over 1 year ago 3 pass, 2 fail - πΊπΈUnited States kreynen
Drupal\Tests\webform_pardot\Unit\PardotHandlerTest::testSubmitDataToPardot Prophecy\Exception\Doubler\ClassMirrorException: Could not reflect class GuzzleHttp\Psr7\FnStream as it is marked final.
Progress?
I'm not entirely sure if I'm just trying to debug an issue with a newer version of Guzzle or something specific to Drupal.org Guzzle errors ( #3292980: Testing system should explain why Guzzle responses can be unreadable β ) yet.
https://www.drupal.org/project/drupal/issues/3285230#comment-14599150 β
https://github.com/guzzle/psr7#fnstream
https://github.com/guzzle/guzzle/blob/7.5/UPGRADING.md#headers-event-has...If anyone more familiar with the Guzzle changes can point me in the right direction, I'd appreciate it.
- last update
over 1 year ago 5 pass - Status changed to Needs review
over 1 year ago 4:57pm 18 April 2023 -
kreynen β
committed 2b3aa46e on 2.0.x authored by
jhedstrom β
Issue #3299492: Automated Drupal 10 compatibility fixes
-
kreynen β
committed 2b3aa46e on 2.0.x authored by
jhedstrom β
- Status changed to Fixed
over 1 year ago 5:44pm 18 April 2023 - πΊπΈUnited States kreynen
@jhedstrom THANKS! It would have taken me a while to get to final classes not being mock-able.
Automatically closed - issue fixed for 2 weeks with no activity.