- πΊπΈUnited States loopy1492
Works for me with zero errors in 9.5.3 and php 8.1. Thanks so much for the work on this one.
- π¦πΊAustralia realityloop
Another RTBC.. Can we please get #12 committed asap this is blocking Drupal 10 upgrade because using it via Composer Patches fails on version constraints because patching occurs after Composer calculates dependencies and installs packages
- Status changed to Needs review
almost 2 years ago 3:13pm 7 February 2023 - πΊπΈUnited States danflanagan8 St. Louis, US
Setting to NW to trigger tests. I just got added as a maintainer here and I'm going to try to get this committed ASAP.
- πΊπΈUnited States danflanagan8 St. Louis, US
Tests did not trigger on the MR. MRs drive me nuts...
Here's a patch version of the MR that I'll run tests against.
The last submitted patch, 19: mrdiff.diff, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
almost 2 years ago 4:08pm 7 February 2023 - πΊπΈUnited States danflanagan8 St. Louis, US
There's something not quite right with the jquery/once updates. The tests fail with the same thing I'm seeing in my console.
It seems like core/once doesn't want to handle
Drupal.ajax.instances
, which is an array.From what I can tell, though, core/once only works on DOM elements. I don't think there's any way (or reason) to use core/once here. I'm going to just back it out completely.
- Status changed to Needs review
almost 2 years ago 4:23pm 7 February 2023 - πΊπΈUnited States danflanagan8 St. Louis, US
Here's an approach that gets rid of the call to
once
which simply won't work with Drupal.ajax.instances as described in #21. -
danflanagan8 β
committed 57f583aa on 8.x-3.x
Issue #3299434 by danflanagan8, AaronBauman, Jaydev Bhatt, Kristen Pol,...
-
danflanagan8 β
committed 57f583aa on 8.x-3.x
- Status changed to Fixed
almost 2 years ago 4:46pm 7 February 2023 - πΊπΈUnited States danflanagan8 St. Louis, US
The patch in #22 passed tests on D9.5. Tests on D10 won't run because the patch itself is updating core_version_requirement. I'll trigger a test against D10.1 manually.
- πΊπΈUnited States danflanagan8 St. Louis, US
Tests passed on D10.1. I just cut a new release that is D10 compatible: https://www.drupal.org/project/viewfield/releases/8.x-3.0-beta7 β
Automatically closed - issue fixed for 2 weeks with no activity.