The expected result from the getNidsByTid function is to always return a node instances, but there could be cases (like mine) that this function is not returning only nodes or there are some relations in the 'taxonomy_index' table which doesn't exists anymore and in such cases the module is not working and it's throwing the following error:
Error: Call to a member function toLink() on null in Drupal\taxonomy_replace\Form\TaxonomyReplaceForm->buildForm(), line 93
I've added a 'join' relation to the query in getNidsByTid(), to be sure that the returned IDs are nodes.
Fixed
1.2
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Issue #3298592: getNidsByTid not always returning a node
Automatically closed - issue fixed for 2 weeks with no activity.