Allow search utils to be removed without causing JS errors

Created on 19 July 2022, over 2 years ago
Updated 1 March 2024, 9 months ago

Problem/Motivation

Disabling the search blocks (in navigation), throw JS errors.

Steps to reproduce

Disable either of Exposed form: sector_sitewide_search-page_1 or Sector blocks - Search desktop fly-out control and a JS error is thrown in control.js and/or search-flyout.js

Proposed resolution

To discuss the best approach to detecting the visibility of the Search functionality and providing a code update to the JS to allow for both scenarios. Could also be an option to look at how each of the libraries are included.

'Control' is used across both menu and search, and the search-flyout is a globally included library. We could remove that from the libraries file, leave it for a block level library include, but still means we need to address the control one firing from both search and menu.

🐛 Bug report
Status

Closed: outdated

Version

9.3

Component

User interface

Created by

🇳🇿New Zealand chroid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024