Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, over 2 years ago
Updated 21 September 2023, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇫🇮Finland back-2-95 Helsinki

    Hi,

    4.12 has still these issues reported by Upgrade Status:

    themes/contrib/radix/templates/dataset/forum-list.html.twig

    Using an "if" condition on "for" tag in "themes/contrib/radix/templates/dataset/forum-list.html.twig" at line 55 is deprecated since Twig 2.10.0, use a "filter" filter or an "if" condition inside the "for" body instead (if your condition depends on a variable updated inside the loop). See https://drupal.org/node/3071078.

    themes/contrib/radix/templates/dataset/forum-list.html.twig

    Using an "if" condition on "for" tag in "themes/contrib/radix/templates/dataset/forum-list.html.twig" at line 68 is deprecated since Twig 2.10.0, use a "filter" filter or an "if" condition inside the "for" body instead (if your condition depends on a variable updated inside the loop). See https://drupal.org/node/3071078.

    themes/contrib/radix/templates/form/select.html.twig

    The spaceless tag in "themes/contrib/radix/templates/form/select.html.twig" at line 19 is deprecated since Twig 2.7, use the "spaceless" filter with the "apply" tag instead. See https://drupal.org/node/3071078.

    radix.info.yml

    The 'seven/global-styling' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.
    themes/contrib/radix/assets/css/radix.style.css 0 The #drupal-off-canvas selector is deprecated in drupal:9.5.0 and is removed from drupal:10.0.0. See https://www.drupal.org/node/3305664 → .

    themes/contrib/radix/radix.info.yml

    Value of core_version_requirement: ^8.7.7 || ^9.0 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

    themes/contrib/radix/src/kits/default/default.info.yml

    Value of core_version_requirement: ^8.7.7 || ^9.0 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

  • Comment over 1 year ago →
    🇬🇧United Kingdom andrew.farquharson

    andrew.farquharson → made their first commit to this issue’s fork.

  • @andrewfarquharson opened merge request.
  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇬🇧United Kingdom andrew.farquharson

    Hi back-2-95 and dixigo, I installed the theme in a Drupal 9.5.0 site and checked out this issue's branch. I then installed the upgrade_manager module. It indicated the radix theme to be compatible with Drupal 10. Although I found the value of core_version_requirement to be correct for Drupal 10, the other issues reported in #7 were still there so I have done fixes for them and pushed- ready to merge.

  • Comment over 1 year ago →
    🇬🇧United Kingdom andrew.farquharson

    I have tested MR !49 on Drupal 9.3.22

  • Comment over 1 year ago →
    🇫🇮Finland back-2-95 Helsinki

    I tested with

    composer req drupal/radix:4.x-dev
    + your MR !49 with Drupal core 9.5.8 and works nicely and Upgrade Status with showing only these left:

    themes/contrib/radix/templates/dataset/forum-list.html.twig

    Using an "if" condition on "for" tag in "themes/contrib/radix/templates/dataset/forum-list.html.twig" at line 68 is deprecated since Twig 2.10.0, use a "filter" filter or an "if" condition inside the "for" body instead (if your condition depends on a variable updated inside the loop). See https://drupal.org/node/3071078.

    radix.info.yml

    The 'seven/global-styling' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.

  • Comment over 1 year ago →
    🇳🇿New Zealand hughmccracken

    Hi this reads like good news - close to making 8.x-4 Dev D10 compatible?

    Any plans for patching 8.x-4.12 similarly? Have a site that is ready for D10 upgrade, just the Radix subtheme to resolve.

    Could I help with testing etc?

  • Comment over 1 year ago →
    🇺🇸United States AaronBauman Philadelphia

    8.x-4.x-dev is D10 compatible.
    I'm running it on a couple sites already

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇳🇿New Zealand ericgsmith

    Hi team,

    It looks like 4.12 was tagged with commit 951476c3, but 3 mins later 0717ca06 was committed with the change to the info file.

    I suspect the intent was to include this in the release? If so can we get a 4.13 tag if this is compatible?

    The project page lists the 4 branch as "Drupal 10 ready" but the core version requirement for 4.12 is still "Works with Drupal: ^8.7.7 || ^9.0"

  • Comment about 1 year ago →
    🇩🇪Germany Rar9

    +1 to get i working with drupal 10

  • Comment about 1 year ago →
    🇺🇸United States eahonet

    I see that same issues as @back-2-95 in comment #7

    Here's a patched meant to address those four items. Since 8.x-4.13 added the || ^10.0

    I'm hoping this means the parent theme will work as I upgrade from d9 > d10.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024