Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, about 2 years ago
Updated 24 June 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot → .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇺🇸United States bvoynick

    Besides core_version_requirement, the only other issue reported by Upgrade Status 4.0.0 is this:

    Class Drupal\field_config_cardinality\Plugin\Field\FieldWidget\CardinalityMediaLibraryWidget extends @internal class Drupal\media_library\Plugin\Field\FieldWidget\MediaLibraryWidget.

    This isn't an incompatibility with Drupal 10. The extended plugin has not changed between 9.5 and 10.0, and I just tested this widget with field_config_cardinality with core 10.0.5.

    I have not tested every other field type with special handling - it does look like there are conditions for a few like managed file - but preliminarily it looks to me like it may be fine to commit the patch from #2 as is.

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States bvoynick
  • First commit to issue fork.
  • @halth opened merge request.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇧🇷Brazil halth Brazil

    Just submitted a MR with the fixes proposed by @bvoynick on #5.

    I'm in agreement with @bvoynick on CardinalityMediaLibraryWidget not being a D10 compatibility issue, since the MediaLibraryWidget class still exists on D10.

  • Comment over 1 year ago →
    System Message
  • Comment over 1 year ago →
    System Message
    • halth → authored 6116d026 on 8.x-2.x 
      Issue #3297188 by halth: Fixed D10 compatibility issues.
  • Comment over 1 year ago →
    🇺🇸United States devkinetic

    Thanks, we now have our first D10 release, 3.0.0!

  • Status changed to Active over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States devkinetic
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    Project Update Bot

    This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

    It is important that any automated tests available are run with this patch and that you manually test this patch.

    Drupal 10 Compatibility

    According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.

    Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.

    Therefore this patch does not update the info.yml file for Drupal 10 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #12554

    This patch was created using these packages:

    1. mglaman/phpstan-drupal: 1.1.35
    2. palantirnet/drupal-rector: 0.15.1
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024