Automated Drupal 10 compatibility fixes

Created on 18 July 2022, almost 2 years ago
Updated 5 October 2023, 9 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects โ†’

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot โ†’ official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot โ†’ .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot โ†’ , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue โ†’ . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue โ†’ using the component โ€œBot: Drupal Rectorโ€.

๐Ÿ“Œ Task
Status

Needs work

Version

3.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • @thalles opened merge request.
  • First commit to issue fork.
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States generalredneck

    I made a couple of commits to the PR so we can use it as a "repository" while the maintainers are absent. composer.json was misnamed as compose.json and it didn't pass validation because it was missing the closing curly brace.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia psingh10
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia psingh10

    Got some issues with the previous one so hiding that.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States generalredneck

    @psingh10,

    Can you summarize the changes you are making from the Merge Reequest. If you didn't know you can start with the patch from there by clicking this link

    Based on what I see I did an interdiff between your two last patches and the thing you changed was commented out the "version" key in info.yml

    Based on an interdiff between the MR and the patch, the composer.json file is removed, druadmin_lte_theme.libraries.yml added core/once and the version key was commented out. I'm going to get your changes in the MR since some people are using composer to access the MR branch directly (like myself).

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States generalredneck

    I've incorporated the changes @psingh10 made into the MR.

  • Status changed to Needs work 9 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Bushra Shaikh

    I applied MR !3 got error:

    error: patch failed: druadmin_lte_theme.info.yml:3
    error: druadmin_lte_theme.info.yml: patch does not apply
    
Production build 0.69.0 2024