- π΅πΉPortugal dmitriy.trt
Dmitriy.trt β made their first commit to this issueβs fork.
- @dmitriytrt opened merge request.
- π΅πΉPortugal dmitriy.trt
Submitted an MR!2 with the patch of #3 and a few more compatibility fixes (see diff).
There is no need to drop Drupal 8 support as tests pass on D8 too.
- Status changed to Needs work
over 1 year ago 5:56pm 13 April 2023 - heddn Nicaragua
The tests are still in a
Tests
folder undersrc
instead of in atests
folder. That alone can't be compatible with Drupal 10. - Status changed to Needs review
over 1 year ago 7:16pm 13 April 2023 - heddn Nicaragua
These tests still pass green after all this time (at least on local). I've followed the applicable points in https://www.drupal.org/docs/automated-testing/converting-simpletests-to-... β to move the namespace.
- First commit to issue fork.
- Status changed to Needs work
over 1 year ago 6:14pm 14 April 2023 - π¬π§United Kingdom scott_euser
Okay I think that's progress at least. Tests updated for the module so they actually run. Now it seems like a few more test failures to get through.
- heddn Nicaragua
I think we need to add
contact_storage
as a test dependency in the .info.yml. Either that or dev dependencies in composer.json. I saw that error locally, and just added it to the site and things just started passing green. - Status changed to Needs review
over 1 year ago 9:23pm 14 April 2023 -
Dmitriy.trt β
committed 2a0d2918 on 8.x-1.x
Issue #3296870: Explicitly enable the access check as it was enabled by...
-
Dmitriy.trt β
committed 2a0d2918 on 8.x-1.x
-
Dmitriy.trt β
committed 6dec7354 on 8.x-1.x
Issue #3296870: Don't enable the entity_reference module from tests It'...
-
Dmitriy.trt β
committed 6dec7354 on 8.x-1.x
-
Dmitriy.trt β
committed 92a76fa8 on 8.x-1.x
Issue #3296870: Explicitly enable the access check as it was enabled by...
-
Dmitriy.trt β
committed 92a76fa8 on 8.x-1.x
-
Dmitriy.trt β
committed 26c44329 on 8.x-1.x
Issue #3296870: Update the core version requirement to make it...
-
Dmitriy.trt β
committed 26c44329 on 8.x-1.x
-
Dmitriy.trt β
committed bb43ea95 on 8.x-1.x
Issue #3296870: Automated Drupal 10 compatibility fixes
-
Dmitriy.trt β
committed bb43ea95 on 8.x-1.x
-
scott_euser β
committed e57b85ae on 8.x-1.x
Issue #3296870 by scott_euser, heddn, Dmitriy.trt, Project Update Bot:...
-
scott_euser β
committed e57b85ae on 8.x-1.x
-
scott_euser β
committed 125506ec on 8.x-1.x
Issue #3296870 by scott_euser, heddn, Dmitriy.trt, Project Update Bot:...
-
scott_euser β
committed 125506ec on 8.x-1.x
- π¬π§United Kingdom scott_euser
Apologies for the spam, I should have read the steps here first re squashing https://www.drupal.org/docs/develop/git/git-for-drupal-project-maintaine... β . Anyways got there in the end after a bit of a mess, all changes from the MR combined in this commit https://git.drupalcode.org/project/contact_emails/-/commit/125506ec86465...
Tagged release to follow shortly
- Status changed to Fixed
over 1 year ago 6:14am 29 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.