Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, over 2 years ago
Updated 11 July 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot → .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇺🇸United States stevenlafl

    Patch to support packagist versions. The bot supplied one will fail.

  • Comment over 1 year ago →
    🇮🇳India yogeshsevak

    After applying #3 facing below error
    Drupal\Core\Extension\InfoParserException: The 'core_version_requirement' constraint (^9.3 || ^10) requires the 'core' key not be set in modules/contrib/ckeditor_quote/ckeditor_quote.info.yml in Drupal\Core\Extension\InfoParserDynamic->parse() (line 88 of core/lib/Drupal/Core/Extension/InfoParserDynamic.php).

    Providing updated patch with fixes. Please review.

  • Comment over 1 year ago →
    🇮🇳India yogeshsevak

    After applying #3 getting below error.
    Drupal\Core\Extension\InfoParserException: The 'core_version_requirement' constraint (^9.3 || ^10) requires the 'core' key not be set in modules/contrib/ckeditor_quote/ckeditor_quote.info.yml in Drupal\Core\Extension\InfoParserDynamic->parse() (line 88 of core/lib/Drupal/Core/Extension/InfoParserDynamic.php).

    Providing updated patch with fixes. Please review. https://www.drupal.org/files/issues/2023-05-03/ckeditor-quote-compatibility-3296771-4.patch →

  • First commit to issue fork.
  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu

    Hi

    patch #4 doesn't apply it give error.

    git apply -v ckeditor-quote-compatibility-3296771-4.patch
    Checking patch src/Plugin/CKEditorPlugin/Quote.php...
    Checking patch ckeditor_quote.info.yml...
    error: while searching for:
    name: CKEditor Quote
    type: module
    description: 'Provides a CKEditor plugin to embed a quote with text and author.'
    core: '8.x'
    core_version_requirement: ^8 || ^9

    # Information added by Drupal.org packaging script on 2020-06-18
    version: '8.x-1.0'

    error: patch failed: ckeditor_quote.info.yml:1
    error: ckeditor_quote.info.yml: patch does not apply

  • Comment over 1 year ago →
    🇮🇳India yogeshsevak

    Providing updated patches with fixes. Please review.
    For 8.x-1.1 : ckeditor-quote-compatibility-3296771-7-1.patch →
    For 8.x-1.x-dev : ckeditor-quote-compatibility-3296771-7.patch →

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇪🇸Spain marcoscano Barcelona, Spain

    I have tested this manually both in D9 and D10, and all looks good to me.
    Attached a slightly modified patch, that doesn't change its nature. It should also fix the issues others reported above about the patch not being applied in the packaged version of the module (which includes some automated metadata to the .info file).
    Credit still should go to the bot :P

    Thanks!

  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇨🇦Canada m4olivei Grimsby, ON

    Not sure why the commit comment hasn't appeared yet, but in any case, I've committed this to a new 2.x branch and tagged a 2.0.0 release.

    Thanks all! 🎉

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024