Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, over 2 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot → .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

Real-physical-testing-round-for-Block-Library-1-0-x-dev--with-d10-and-d9.zip →

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Comment almost 2 years ago →
    🇯🇴Jordan Rajab Natshah Jordan

    Upgrade Status report

    Block Library 1.0.0-alpha2

    Scanned on Sun, 01/29/2023 - 20:48.
    2 errors found. 3 warnings found.

    Fix now with automation

    Check manually

    Errors without Drupal source version numbers including parse errors and use of APIs from dependencies.
  • Comment almost 2 years ago →
    🇯🇴Jordan Rajab Natshah Jordan

    phpcs --standard=Drupal

    rajab@vardot-dev:/var/www/html/modules/block_library$ phpcs --standard=Drupal --extensions=php,inc,install,test,profile,theme,css,info,txt,md,yml,js /var/www/html/modules/block_library/

    phpcs --standard=DrupalPractice

    rajab@vardot-dev:/var/www/html/modules/block_library$ phpcs --standard=DrupalPractice --extensions=php,inc,install,test,profile,theme,css,info,txt,md,yml,js /var/www/html/modules/block_library/
  • Comment almost 2 years ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Comment almost 2 years ago →
    🇯🇴Jordan Rajab Natshah Jordan
    PHP Fatal error:  Declaration of Drupal\block_library\Routing\RouteSubscriber::getSubscribedEvents() must be compatible with Drupal\Core\Routing\RouteSubscriberBase::getSubscribedEvents(): array in /var/www/html/sandboxes/drupal10block_library_1__test/web/modules/contrib/block_library/src/Routing/RouteSubscriber.php on line 28
  • Comment almost 2 years ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Comment almost 2 years ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Comment almost 2 years ago →
    🇯🇴Jordan Rajab Natshah Jordan

    When creating a new block type with an icon

    The website encountered an unexpected error. Please try again later.
TypeError: mb_strlen(): Argument #1 ($string) must be of type string, array given in mb_strlen() (line 333 of core/lib/Drupal/Core/Form/FormValidator.php).
mb_strlen() (Line: 333)
Drupal\Core\Form\FormValidator->performRequiredValidation() (Line: 246)
Drupal\Core\Form\FormValidator->doValidateForm() (Line: 238)
Drupal\Core\Form\FormValidator->doValidateForm() (Line: 238)
Drupal\Core\Form\FormValidator->doValidateForm() (Line: 118)
Drupal\Core\Form\FormValidator->validateForm() (Line: 591)
Drupal\Core\Form\FormBuilder->processForm() (Line: 323)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult() (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 58)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 23)
Stack\StackedHttpKernel->handle() (Line: 713)
Drupal\Core\DrupalKernel->handle() (Line: 19)
  • Comment almost 2 years ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Comment almost 2 years ago →
    🇯🇴Jordan Rajab Natshah Jordan

    Had Real physical testing round for Block Library 1.0.x-dev with Drupal ~10

    also
    Had Real physical testing round for Block Library 1.0.x-dev with Drupal ~9

    using the attached bash commands

  • @rajab-natshah opened merge request.
  • Comment almost 2 years ago →
    System Message
  • Status changed to Fixed almost 2 years ago
  • Comment almost 2 years ago →
    🇨🇦Canada mahmoud-zayed
  • Status changed to Fixed almost 2 years ago
  • Comment almost 2 years ago →
    🇨🇦Canada mahmoud-zayed

    Thanks Rajab :)

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024