Automated Drupal 10 compatibility fixes

It looks to me like the thing that is need most here to get this done is telling ableplayer.info.yml that the module is compatible with Drupal 10

Based on these deprecated functions/methods I suggest it be changed to

core_version_requirement: ^9.3 || ^10

drupal_get_path(): ^9.3
render: ^9.3
UiHelperTrait::drupalPostForm: ^9.1

here is a patch that will do just that

Thanks jrglasgow. The patch has been applied to 3.x-dev.

Also on 3.x-dev are updated templates using apply spaceless and endapply in place of spaceless and endspaceless which are not valid in D10 twig.

file_get_url has also been replaced.

@theMusician - I don't see the patch having been applies to the 1.x branch in the repository.

Can you please check again, or just merge the pull request.

It is merged into 3.x-dev. https://git.drupalcode.org/project/ableplayer/-/blob/3.x-dev/ableplayer....

When you said it was merged into 3.x-dev I took a look at the source code link in the right sidebar

which links to https://git.drupalcode.org/project/ableplayer which shows the default branch "3.x" not "3.x-dev"

I suppose the question would be... why is there a 3.x branch along with a 3.x-dev branch? Seems kind of redundant to me, not to mention it leads to a bit of confusion as Drupal.org will automatically create a release called 3.x-dev whenever the 3.x branch is updated, if you opt to have development releases for that branch. Take a look at the Release naming conventions - Release branches and tags - Release branches →

Thank you for the tip. I'll try to clean that up later this week. I can see how the dev branch would be causing confusion. Certainly not my intent.

Max

any chance we can get a release where the info file says it is compatible with Drupal 10?

Alpha6 is out now with the D10 info file. Thanks for the support on the project jrglasgow.

The 3.x branch is now getting the Drupalbot attention