Move the gtag_domain condition plugin to a submodule

I have the exact same problem where the Domain module is not enabled and this breaks the Condition Plugin System, so that it is no longer possible to edit fields using the plugin select list plugin selector.

@solotandem: What issues do you mean by?

My preference would be to see core commit a simple change (see other issues) which would make this problem go away.

From my understanding, we could also use the calculateDependencies in the dependency plugin.

public function calculateDependencies() {
  return parent::calculateDependencies() + [
      'module' => ['domain'],
    ];
}

Unfortunately this was not working on my existing site.

@solotandem it would be easier to understand your proposed approach if "see other issues" linked to the mentioned "simple change" that you hope to see core commit. Without that context it's not clear what you hope might address the challenge.

For Acquia sites using that Domain condition plugin in 8.x-1.x series and not available in 2.0.x, the requirement to update to Google Tag 2.0.x (acquia/acquia_cms 2.2.0 requires drupal/google_tag (^2.0)) may be a sticking point.

If your comment pointed to the relevant issue then folks hitting this issue would be better able to consider the approach you're proposing.

Is the Google Tag Domain module redundant by way of Domain module's domain plugin?

If so, the configuration change to switch may look like this:

 conditions:
-  gtag_domain:
-    id: gtag_domain
+  domain:
+    id: domain
+    negate: false
     context_mapping:
-      'entity:domain': '@domain.current_domain_context:domain'
-    domain_toggle: 'include listed'
-    domain_list:
+      domain: '@domain.current_domain_context:domain'
+    domains:
       yourdomain: yourdomain

Yes xurizaemon, the Domain module's own plugin seems to work in an identical fashion.

Based on my and Patrick assessment, it seems the gtag_domain plugin can be dropped, replaced with the domain condition plugin from Domain module.

- https://git.drupalcode.org/project/domain/-/blob/8.x-1.x/domain/src/Plug...

Updated ID. Proactively closing "won't fix" - anyone is welcome to pick this up and run with it in the direction of their choice :)