Drupal 10 compatibility and fixing tests with latest commerce

I'm new to patching/contributing, but here's my attempt. Any feedback is MORE than welcome.

Ok,
So after at least getting the patch to apply, I'm at a loss. It seems like I'm getting the same errors as @Berdir. Happy to continue to work on this but I need some guidance. Thank you in advance.

Since this is also failing on D9 I assume the test fails are already on HEAD, although there is one extra test fail on the D10 patch.

You picked a fairly challenging issue, there is not really a shortcut here, the way forward here is to set those tests up locally, run them, then look at the output to see if you can figure out what's going on. The extra D10 test fail might throw an error or exception, the others are likely a change in Commerce or the Commerce test setup.

Here's a patch to just get me to D10. I've removed the tests for now.

There is no need to remove tests. Failing tests don't bother your project and it makes further contributions harder. I don't know if there's a difference in non-test code now between those two patches.

@Berdir Thank you for your help. Too many patches and apparently merge requests are the way to go these days. I've made the same changes and left the tests intact. Happy to keep working on this if there are still outstanding issues.

I have this error when generating a new giftcard Error: Call to undefined method Drupal\mysql\Driver\Database\mysql\Select::accessCheck() line 63 of /commerce_giftcard/src/GiftcardCodeGenerator.php patch #8.
Erasing that line 63 (->accessCheck(TRUE)) I can generate again without failures.

@rubenjara,

Are you sure you have the correct permissions set?

@rsnyd The error happens with the administrator user, permissions are activated. Here's another similar report 🐛 Error: Call to undefined method Drupal\mysql\Driver\Database\mysql\Select::accessCheck() Fixed .

@rubenjara,
Ok, I understand what you're saying, but I don't see that line of code in this fork/branch. (https://git.drupalcode.org/issue/commerce_giftcard-3295499/-/blob/329549...)

@everyone,
This issue is ready for review. Can anyone from the community review and test these changes?

Looks and works fine