Drupal 10 compatibility and fixing tests with latest commerce

I'm new to patching/contributing, but here's my attempt. Any feedback is MORE than welcome.

Ok,
So after at least getting the patch to apply, I'm at a loss. It seems like I'm getting the same errors as @Berdir. Happy to continue to work on this but I need some guidance. Thank you in advance.

Since this is also failing on D9 I assume the test fails are already on HEAD, although there is one extra test fail on the D10 patch.

You picked a fairly challenging issue, there is not really a shortcut here, the way forward here is to set those tests up locally, run them, then look at the output to see if you can figure out what's going on. The extra D10 test fail might throw an error or exception, the others are likely a change in Commerce or the Commerce test setup.

Here's a patch to just get me to D10. I've removed the tests for now.

There is no need to remove tests. Failing tests don't bother your project and it makes further contributions harder. I don't know if there's a difference in non-test code now between those two patches.

@Berdir Thank you for your help. Too many patches and apparently merge requests are the way to go these days. I've made the same changes and left the tests intact. Happy to keep working on this if there are still outstanding issues.

I have this error when generating a new giftcard Error: Call to undefined method Drupal\mysql\Driver\Database\mysql\Select::accessCheck() line 63 of /commerce_giftcard/src/GiftcardCodeGenerator.php patch #8.
Erasing that line 63 (->accessCheck(TRUE)) I can generate again without failures.

@rubenjara,

Are you sure you have the correct permissions set?

@rsnyd The error happens with the administrator user, permissions are activated. Here's another similar report 🐛 Error: Call to undefined method Drupal\mysql\Driver\Database\mysql\Select::accessCheck() Fixed .

@rubenjara,
Ok, I understand what you're saying, but I don't see that line of code in this fork/branch. (https://git.drupalcode.org/issue/commerce_giftcard-3295499/-/blob/329549...)

@everyone,
This issue is ready for review. Can anyone from the community review and test these changes?

Looks and works fine

Any plans to release it as a new version?

@Berdir: Ping to merge this, if this is fine for you. Is this module eventually even ready for an alpha release to get away from the .dev need?

Once fixed we should start working on the Drupal 11 compatibility. We're not actively using the module, but it looks like Berdir could need some help or active Co-maintainers?

Hi @Anybody: my issue regarding the Drupal 10 installation error was closed because it was considered similar to a post here.

However, this post hasn't been updated in almost a year, and I'm unsure which patch to apply for installing this module on a Drupal 10 website currently. Can anyone provide updated guidance or a relevant patch?

@eit2103,
I'm on 10.2.2 and currently using commerce_giftcard in production. Although, I will say, we are currently having issues that I am investigating, but this setup was working until recently.

From my composer:

"drupal/commerce_giftcard": "dev-3295499-drupal-10-compatibility",

patches:

"drupal/commerce_giftcard": {
"3180964-5: Theme hook commerce_giftcard_redemption_form not found": " https://www.drupal.org/files/issues/2021-12-13/theme_hook_commerce_giftc... → ",
"3184543: Gift card should generate standard commerce events": " https://www.drupal.org/files/issues/2020-11-24/commerce_giftcard-modify-... → "
},

Let's move this on to Drupal 11.

Thanks all! 2.x is in progress!

Automatically closed - issue fixed for 2 weeks with no activity.