Contrib.social

Rewrite code comment in editor.admin.es6.js about tag allowing and removing with a non-empty universe

Open on Drupal.org →
Created on 11 July 2022, over 2 years ago
Updated 19 February 2024, about 1 year ago

Problem/Motivation

During #3151100: Replace use of whitelist/blacklist in CkEditor and Editor modules → , we ran into a code comment in editor.admin.es6.js that we were trying to rewrite to use allow / remove terminology. However, myself, @alexpott, and various other contributors couldn't make sense of the original intent of the comment, so re-writing it proved difficult. For now, we tried to do a directly replace of the previous phrases with "allow" and "remove", but the resulting word soup doesn't make sense:

          // Every tag was explicitly allowed, but since the universe is not
          // empty, one or more tag properties are disallowed. However, if only
          // removing of tag properties was applied to these tags, and no
          // "allowing" was ever applied, then it's still fine.  Since none of
          // the tag properties were removed, we got to this point, and since no
          // "allowing" was applied, it doesn't matter that the properties could
          // never have happened anyway. It's only this late that we can know
          // this for certain.

Steps to reproduce

Look at core/modules/editor/js/editor.admin.es6.js.

Proposed resolution

Rewrite the comment to make sense. 😅

Remaining tasks

  1. Get Wim, the original author, to explain what they meant.
  2. Turn it into something other developers can understand. 😉
  3. MR / patch to update the comment.
  4. Reviews / refinements.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

📌 Task
Status

Closed: won't fix

Version

11.0 🔥

Component
Editor  →

Last updated about 1 hour ago

Created by

🇺🇸United States dww

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024