Handle forms without base form ID

Created on 7 July 2022, over 2 years ago

Updated 24 July 2023, over 1 year ago

Some forms do not have a base form ID. In this case, FormBaseAlterEvent::getBaseFormId() raises a type error because it would return NULL.

Since the refactoring in #3277301: Adapt to centralised hook dispatcher in Drupal 9.4 → , it seems like we need some way for events to state they should not dispatch.

Attempt to render a form with no base form (it does not extend an existing form.)

Provide a method for events to short-circuit dispatching in ::getDispatcherType().

Review, tests?

None

Some return types are now nullable.

None.

🐛 Bug report

Status

Fixed

Version

4.0

Component

Code

Created by

🇺🇸United States bradjones1 Digital Nomad Life

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
System Message

el7cosmos → committed ffaad163 on gitlab-ci
Issue #3294805 by el7cosmos, bradjones1: Handle forms without base form...
Issue was unassigned.
Status changed to Fixed over 1 year ago11:30am 24 July 2023
Comment over 1 year ago →
🇮🇩Indonesia el7cosmos 🇮🇩 GMT+7
This fix is not going to work for the future 4.x branch because the property $baseFormId is declared as a string so you can not even assign NULL to it.

This was fixed in https://git.drupalcode.org/project/hook_event_dispatcher/-/commit/3e9402...
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024