- ๐ง๐ทBrazil luizsgpetri Campinas
Hi, I rerolled the patch up to 8.3.3 version.
I wasn't able to create an interdiff file because the previous patch doesn't apply anymore.
I've found out that In some cases the getAwsErrorMessage() method is returns an empty string. Like when we try to use an nonexistent bucket.
So I've added a fallback to it.All the comments in the previous patch are now resolved but the one related with providing a fallback to the logger parameter. It mentioned that this would be needed because we were in beta, which doesn't seems to be the case anymore.
- Status changed to Needs review
over 1 year ago 1:23pm 8 August 2023 - last update
over 1 year ago 78 pass - Status changed to Needs work
over 1 year ago 5:32pm 8 August 2023 - ๐บ๐ธUnited States cmlara
It mentioned that this would be needed because we were in beta, which doesn't seems to be the case anymore.
Itโs a โonce a BETA release is made, BC measure should be doneโ which especially applies to Stable since we didnโt mark the class internal it may be being extended.
The simple fallback for this is, when the parameter is null fallback to calling \Drupal::service() to get the logger and raise a deprecation notice.
-
cmlara โ
committed 0ff75d7b on 8.x-3.x authored by
szantog โ
Issue #3293269 by cmlara, szantog, luizsgpetri: Improve error logging
-
cmlara โ
committed 0ff75d7b on 8.x-3.x authored by
szantog โ
- Status changed to Downport
about 1 year ago 10:45pm 7 December 2023